fix off-by-one out-of-bounds write in EmulatedCharset.getBytes#10326
Open
metsw24-max wants to merge 1 commit into
Open
fix off-by-one out-of-bounds write in EmulatedCharset.getBytes#10326metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
Member
|
Thanks - at a quick glance that looks correct, and confirmed that the test fails without the change (and passes with it). The fork Google made also appears to need this fix: https://github.com/google/j2cl/blob/master/jre/java/javaemul/internal/EmulatedCharset.java |
Author
|
Good point, the LatinCharset code is identical over there. I'll send the same one-line fix to j2cl. |
zbynek
approved these changes
Jun 1, 2026
zbynek
added
the
ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed LatinCharset.getBytes writes bytes[i] while i runs from offset, but bytes is only count long. So OutputStreamWriter.write(buf, offset, count) with a non-zero offset on ISO-8859-1/Latin-1 writes past the output array and leaves bytes[0..offset) unwritten; the precondition check only validates offset/count against the input buffer. Index the destination with i - offset.